iffyio commented on code in PR #2034:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2034#discussion_r2362118563
##########
src/dialect/mod.rs:
##########
@@ -898,6 +898,11 @@ pub trait Dialect: Debug + Any {
false
}
+ /// Returns true if the dialect supports hint and C-style comments
Review Comment:
Can we add an example here? I think it won't be clear otherwise what this
means by only reading the description
##########
src/tokenizer.rs:
##########
@@ -4070,4 +4101,39 @@ mod tests {
panic!("Tokenizer should have failed on {sql}, but it succeeded
with {tokens:?}");
}
}
+ #[test]
+ fn tokenize_multiline_comment_with_c_style_comment() {
+ let sql = String::from("0/*! word */1");
Review Comment:
Looking at their docs, I'm wondering if/how we support these examples?
```sql
SELECT /*! STRAIGHT_JOIN */ col1 FROM table1,table2
/*!50110 KEY_BLOCK_SIZE=1024 */
SELECT /*! BKA(t1) */ FROM T
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
