findepi commented on code in PR #17491:
URL: https://github.com/apache/datafusion/pull/17491#discussion_r2339733259
##########
datafusion/functions/src/datetime/to_local_time.rs:
##########
@@ -119,6 +119,7 @@ impl ToLocalTimeFunc {
let arg_type = time_value.data_type();
match arg_type {
+ DataType::Null => Ok(ColumnarValue::Scalar(ScalarValue::Null)),
Review Comment:
@alamb good idea. Or maybe somewhere higher up, genericly for very physical
expr?
draft
- https://github.com/apache/datafusion/pull/17515
@petern48 if the function promised to return a value of type
`DataType::Timestamp(Nanosecond, None)` during planning it needs to do so
during execution. `ScalarValue::Null` has type `DataType::Null`, so it's a
different type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
