findepi commented on code in PR #17645:
URL: https://github.com/apache/datafusion/pull/17645#discussion_r2362710967
##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -1310,8 +1310,8 @@ async fn test_count_wildcard() -> Result<()> {
@r"
Sort: count(*) ASC NULLS LAST [count(*):Int64]
Projection: count(*) [count(*):Int64]
- Aggregate: groupBy=[[test.b]], aggr=[[count(Int64(1)) AS count(*)]]
[b:UInt32, count(*):Int64]
- TableScan: test [a:UInt32, b:UInt32, c:UInt32]
+ Aggregate: groupBy=[[test.b]], aggr=[[count(Int64(1)) AS count(*)]]
[test.b:UInt32, count(*):Int64]
+ TableScan: test [test.a:UInt32, test.b:UInt32, test.c:UInt32]
Review Comment:
For TableScan, however. the schema printing code is same for every plan node
and for many it's not much less clear. Without this change, the plan printout
is incomplete and insufficient to understand the plan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
