alamb commented on code in PR #17645:
URL: https://github.com/apache/datafusion/pull/17645#discussion_r2380054357
##########
datafusion/core/tests/dataframe/dataframe_functions.rs:
##########
@@ -1310,8 +1310,8 @@ async fn test_count_wildcard() -> Result<()> {
@r"
Sort: count(*) ASC NULLS LAST [count(*):Int64]
Projection: count(*) [count(*):Int64]
- Aggregate: groupBy=[[test.b]], aggr=[[count(Int64(1)) AS count(*)]]
[b:UInt32, count(*):Int64]
- TableScan: test [a:UInt32, b:UInt32, c:UInt32]
+ Aggregate: groupBy=[[test.b]], aggr=[[count(Int64(1)) AS count(*)]]
[test.b:UInt32, count(*):Int64]
+ TableScan: test [test.a:UInt32, test.b:UInt32, test.c:UInt32]
Review Comment:
I was more thinking how redundant this line is now
It goes from
```diff
- TableScan: test [a:UInt32, b:UInt32, c:UInt32]
+ TableScan: test [test.a:UInt32, test.b:UInt32, test.c:UInt32]
```
That is the qualifier `test` is now repeated **4** times. It will be even
worse when there are
1. long qualifiers "my_really_obxiously_long_table_name"
2. Multiple columns selected as each column gets the same name
For a TableScan, there can be, by definition, only a single relation, so
appending the relation name to all expressions just makes the plans harder to
read
More generally, when there is only one relation in the query, as is the case
in many queries, adding a qualifier to all expressions I think makes the plans
harder to read, not better
```
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
