coderfender commented on code in PR #2136:
URL: https://github.com/apache/datafusion-comet/pull/2136#discussion_r2379463340
##########
native/core/src/execution/planner.rs:
##########
@@ -1007,21 +1000,25 @@ impl PhysicalPlanner {
}
_ => {
let data_type = return_type.map(to_arrow_datatype).unwrap();
- if eval_mode == EvalMode::Try && data_type.is_integer() {
+ if [EvalMode::Try, EvalMode::Ansi].contains(&eval_mode)
+ && (data_type.is_integer()
+ || (data_type.is_floating() && op ==
DataFusionOperator::Divide))
Review Comment:
Thank you for the comment. All division in comet is float or decimal
division . I have had to add this check to make sure that float operands are
supported only when the operation is division and the existing tests should
cover this . I also have a draft PR ready for supporting Integral division
https://github.com/apache/datafusion-comet/pull/2421 which should be the ready
for review once this is merged :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
