andygrove commented on code in PR #2430:
URL: https://github.com/apache/datafusion-comet/pull/2430#discussion_r2372537185
##########
.github/actions/java-test/action.yaml:
##########
@@ -62,6 +62,43 @@ runs:
run: |
./mvnw -B compile test-compile scalafix:scalafix -Dscalafix.mode=CHECK
-Psemanticdb ${{ inputs.maven_opts }}
+ - name: Check for documentation changes
+ shell: bash
+ run: |
+ # Capture the initial state of docs before we potentially regenerate
them
+ echo "Checking documentation consistency..."
+
+ # Configure git for safe directory access in container
+ git config --global --add safe.directory "$(pwd)"
Review Comment:
This seems overly complex. I think we can just run a `git diff` to see if
there are local changes?
ChatGPT suggested:
```
- name: Fail if there are uncommitted changes
run: |
if ! git diff --quiet || ! git diff --cached --quiet; then
echo "❌ Found uncommitted changes after build/format"
git status
git diff
exit 1
fi
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
