alamb commented on PR #17419:
URL: https://github.com/apache/datafusion/pull/17419#issuecomment-3338118968
Aha -- the benchmark is not running because it is panic'ing on this branch:
To reproduce:
```shell
cargo bench --profile dev --bench sql_planner -- physical_plan_tpcds_all
```
This passes on main
It panic's on this branch like this:
```shell
Benchmarking physical_plan_tpcds_all: Warming up for 3.0000 s
thread 'main' panicked at datafusion/core/benches/sql_planner.rs:64:14:
called `Result::unwrap()` on an `Err` value: Internal("Physical input schema
should be the same as the one converted from logical input schema. Differences:
\n\t- field nullability at index 5 [sales_cnt]: (physical) true vs (logical)
false\n\t- field nullability at index 6 [sales_amt]: (physical) true vs
(logical) false")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
That is somewhat bad that all the tests pass too 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
