andygrove commented on code in PR #2425:
URL: https://github.com/apache/datafusion-comet/pull/2425#discussion_r2382571670
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1034,6 +1034,24 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateDecimalsPrecision10Scale2(),
DataTypes.createDecimalType(10, 0))
}
+ test("cast ArrayType to StringType") {
+ sql("set spark.comet.explainFallback.enabled=true")
Review Comment:
We tend to use `withSQLConf` to set configs in tests so that the config
change is isolated to the specific test.
```suggestion
withSQLConf(CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.key -> "true") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
