andygrove opened a new issue, #2469:
URL: https://github.com/apache/datafusion-comet/issues/2469

   ### Describe the bug
   
   Regression was introduced in 
https://github.com/apache/datafusion-comet/pull/2178
   
   We only run the tests if the scan is auto mode:
   
   ```scala
     if (CometConf.COMET_NATIVE_SCAN_IMPL.get() == CometConf.SCAN_AUTO) {
       tpcdsQueriesV2_7_0.foreach { q =>
         test(s"check simplified (tpcds-v2.7.0/$q)") {
           testQuery("tpcds-v2.7.0", q)
         }
       }
     }
   ```
   
   We use an env var to specify scan type:
   
   ```yaml
       - name: Run all tests
         shell: bash
         if: ${{ inputs.suites == '' }}
         env:
           COMET_PARQUET_SCAN_IMPL: ${{ inputs.scan_impl }}
   ```
   
   The PR builds never specify auto:
   
   ```yaml
             - name: "Spark 3.5.5, JDK 17, Scala 2.13"
               java_version: "17"
               maven_opts: "-Pspark-3.5 -Dspark.version=3.5.5 -Pscala-2.13"
               scan_impl: "native_comet"
   
   ```
   
   ### Steps to reproduce
   
   _No response_
   
   ### Expected behavior
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to