mbutrovich commented on code in PR #2462:
URL: https://github.com/apache/datafusion-comet/pull/2462#discussion_r2383376194
##########
spark/src/main/scala/org/apache/comet/CometExecIterator.scala:
##########
@@ -93,6 +93,14 @@ class CometExecIterator(
}
val protobufSparkConfigs = builder.build().toByteArray
+ val memoryLimitPerTask = if (offHeapMode) {
+ // this per-task limit is not used in native code when using unified
memory
+ // so we can skip calculating it and avoid logging irrelevant information
+ 0
Review Comment:
Do we expect it to be called in off-heap mode or should we do something more
dramatic like throw an exception here because it means something is wrong on
the native side and we'll quietly return a 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
