SparkApplicationMaster commented on code in PR #17779:
URL: https://github.com/apache/datafusion/pull/17779#discussion_r2386400640


##########
datafusion/sqllogictest/test_files/spark/map/map_from_entries.slt:
##########


Review Comment:
   Thank you for examples!
   Added some tests for input with nulls:
   1) nulltype instead of array (failed as expected)
   2) array with nulltype instead of struct (failed as expected)
   3) array with null key (failed as expected)
   4) array with null entries - this was failing instead of returning correct 
result
   so added and rewritten some code to fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to