alamb commented on code in PR #17888:
URL: https://github.com/apache/datafusion/pull/17888#discussion_r2399535839
##########
datafusion-examples/examples/flight/flight_client.rs:
##########
@@ -34,7 +35,9 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
let testdata = datafusion::test_util::parquet_test_data();
// Create Flight client
- let mut client =
FlightServiceClient::connect("http://localhost:50051";).await?;
+ let endpoint = Endpoint::new("http://localhost:50051";)?;
Review Comment:
This is due to new version of tonic
##########
datafusion-examples/examples/flight/flight_server.rs:
##########
@@ -106,6 +106,7 @@ impl FlightService for FlightServiceImpl {
// add an initial FlightData message that sends schema
let options = arrow::ipc::writer::IpcWriteOptions::default();
+ let mut compression_context = CompressionContext::default();
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/8405
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -710,13 +710,13 @@ select
query TTT
select arrow_typeof(column1), arrow_typeof(column2), arrow_typeof(column3)
from arrays;
----
-List(Field { name: "item", data_type: List(Field { name: "item", data_type:
Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }),
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field
{ name: "item", data_type: Float64, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type:
Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
-List(Field { name: "item", data_type: List(Field { name: "item", data_type:
Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }),
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field
{ name: "item", data_type: Float64, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type:
Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
-List(Field { name: "item", data_type: List(Field { name: "item", data_type:
Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }),
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field
{ name: "item", data_type: Float64, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type:
Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
-List(Field { name: "item", data_type: List(Field { name: "item", data_type:
Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }),
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field
{ name: "item", data_type: Float64, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type:
Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
-List(Field { name: "item", data_type: List(Field { name: "item", data_type:
Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }),
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field
{ name: "item", data_type: Float64, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type:
Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
-List(Field { name: "item", data_type: List(Field { name: "item", data_type:
Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }),
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field
{ name: "item", data_type: Float64, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type:
Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
-List(Field { name: "item", data_type: List(Field { name: "item", data_type:
Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }),
nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} }) List(Field
{ name: "item", data_type: Float64, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }) List(Field { name: "item", data_type:
Utf8, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: {} })
+List(nullable List(nullable Int64)) List(nullable Float64) List(nullable Utf8)
Review Comment:
Many of the diffs in this file are related to improvements in `DataType
`display, tracked in this ticket
- https://github.com/apache/arrow-rs/issues/8351
I will try and call out individual changes when I see them. Lists are way
nicer now:
- https://github.com/apache/arrow-rs/pull/8290
##########
datafusion/substrait/Cargo.toml:
##########
@@ -39,7 +39,7 @@ itertools = { workspace = true }
object_store = { workspace = true }
pbjson-types = { workspace = true }
prost = { workspace = true }
-substrait = { version = "0.58", features = ["serde"] }
+substrait = { version = "0.59", features = ["serde"] }
Review Comment:
since prost is updated, we also must update substrait
##########
datafusion/functions-aggregate-common/src/utils.rs:
##########
@@ -145,8 +148,11 @@ impl<T: DecimalType> DecimalAverager<T> {
if let Ok(value) =
sum.mul_checked(self.target_mul.div_wrapping(self.sum_mul)) {
let new_value = value.div_wrapping(count);
- let validate =
- T::validate_decimal_precision(new_value,
self.target_precision);
+ let validate = T::validate_decimal_precision(
Review Comment:
Due to this (get better messages)
- https://github.com/apache/arrow-rs/pull/8396
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -6408,7 +6408,7 @@ physical_plan
04)------AggregateExec: mode=Partial, gby=[], aggr=[count(Int64(1))]
05)--------ProjectionExec: expr=[]
06)----------CoalesceBatchesExec: target_batch_size=8192
-07)------------FilterExec: substr(md5(CAST(value@0 AS Utf8View)), 1, 32) IN
([Literal { value: Utf8View("7f4b18de3cfeb9b4ac78c381ee2ad278"), field: Field {
name: "lit", data_type: Utf8View, nullable: false, dict_id: 0, dict_is_ordered:
false, metadata: {} } }, Literal { value: Utf8View("a"), field: Field { name:
"lit", data_type: Utf8View, nullable: false, dict_id: 0, dict_is_ordered:
false, metadata: {} } }, Literal { value: Utf8View("b"), field: Field { name:
"lit", data_type: Utf8View, nullable: false, dict_id: 0, dict_is_ordered:
false, metadata: {} } }, Literal { value: Utf8View("c"), field: Field { name:
"lit", data_type: Utf8View, nullable: false, dict_id: 0, dict_is_ordered:
false, metadata: {} } }])
+07)------------FilterExec: substr(md5(CAST(value@0 AS Utf8View)), 1, 32) IN
([Literal { value: Utf8View("7f4b18de3cfeb9b4ac78c381ee2ad278"), field: Field {
name: "lit", data_type: Utf8View } }, Literal { value: Utf8View("a"), field:
Field { name: "lit", data_type: Utf8View } }, Literal { value: Utf8View("b"),
field: Field { name: "lit", data_type: Utf8View } }, Literal { value:
Utf8View("c"), field: Field { name: "lit", data_type: Utf8View } }])
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/8290
##########
datafusion/sqllogictest/test_files/arrow_typeof.slt:
##########
@@ -61,13 +61,13 @@ Decimal128(38, 10)
query T
SELECT arrow_typeof(now()::timestamp)
----
-Timestamp(Nanosecond, None)
+Timestamp(ns)
Review Comment:
Due to
- https://github.com/apache/arrow-rs/pull/8425
##########
datafusion/sqllogictest/test_files/arrow_typeof.slt:
##########
@@ -237,6 +237,31 @@ drop table foo
## Timestamps: Create a table
+statement ok
Review Comment:
The timestamp format has changed (improved!) so let's also add tests for the
new format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
