alamb commented on code in PR #17888:
URL: https://github.com/apache/datafusion/pull/17888#discussion_r2421929446
##########
datafusion-cli/src/main.rs:
##########
@@ -585,9 +585,9 @@ mod tests {
+-----------------------------------+-----------------+---------------------+------+------------------+
| filename | file_size_bytes |
metadata_size_bytes | hits | extra |
+-----------------------------------+-----------------+---------------------+------+------------------+
- | alltypes_plain.parquet | 1851 | 10181
| 2 | page_index=false |
- | alltypes_tiny_pages.parquet | 454233 | 881418
| 2 | page_index=true |
- | lz4_raw_compressed_larger.parquet | 380836 | 2939
| 2 | page_index=false |
+ | alltypes_plain.parquet | 1851 | 7166
| 2 | page_index=false |
Review Comment:
I am not sure why the heap size of the metadata is reported to be so much
smaller. I don't expect our thrift decoding work to have reduce the in-memory
size of the parquet metadata 🤔
@etseidl any ideas? I can perhaps go audit the `heap_size` implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
