vegarsti commented on code in PR #17891:
URL: https://github.com/apache/datafusion/pull/17891#discussion_r2415592338
##########
datafusion/functions-nested/src/array_has.rs:
##########
@@ -145,6 +145,7 @@ impl ScalarUDFImpl for ArrayHas {
let list = scalar_values
.into_iter()
.flatten()
+ .flatten()
Review Comment:
But agh the comment here is wrong - with the `flatten` instead of your
suggested change we _don't_ pass the test we added. Which should we pick? If we
keep the flatten I guess we need to change the test. I've updated the test but
now as you have pointed out, it's not correct 😬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
