rluvaton opened a new issue, #18002: URL: https://github.com/apache/datafusion/issues/18002
Merge when ready use the commits as the merge commit body, however a lot of times (at least for me) the commits message in pull request are not it should instead use the pull request description as the commit message body as it contains more information Here’s a cleaner, more polished issue title and body you can use: ⸻ Currently, the _Merge when ready_ feature uses the individual commit messages as the merge commit body. However, in many cases — especially for larger pull requests — the individual commits contain incremental or low-signal changes (e.g. "fix typo", "rename param", "cleanup"), which makes the resulting merge commit body noisy and uninformative. Instead, it would be more useful if _Merge when ready_ used the pull request description as the merge commit body, since we have a template for pull request and they usually provide clearer info ## Examples of merge commits that would benefit from pull request description https://github.com/apache/datafusion/commit/5472e5da30bb5de5bd7a75784d39553fd05f0a66 ``` * clean up duplicate information in FileOpener trait * remove unused struct * remove more * rename paramter * more renames * minimize diff * fix renames * fix renames * more fixes ``` Another example: https://github.com/apache/datafusion/commit/f8e988f8309a6b2b4b893f541cc68b769ac50d22 ``` * Chore: Migrate avg from comet to datafusion-spark and add a few tests. * CI Fix: Apply cargo format. * CI Fix: Add coerce types function. * Add group by tests to the suite. * Add doc highlighting differences with Spark. * CI assertion error fixes and improved docs. --------- Co-authored-by: sriram <[email protected]> ``` ---- Documentation on how to change it from `apache/infrastructure-asfyaml`: https://github.com/apache/infrastructure-asfyaml#merge-buttons -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
