2010YOUY01 commented on PR #17482: URL: https://github.com/apache/datafusion/pull/17482#issuecomment-3395887692
How about first splitting the 'in-equality predicate extracting logic' into a different PR? The idea is described in https://github.com/apache/datafusion/pull/17482#issuecomment-3280088456 The current planning logic is not correct, and the above link points to several existing utils to handle this case easily ``` > set datafusion.optimizer.allow_piecewise_merge_join = true; 0 row(s) fetched. Elapsed 0.002 seconds. > explain SELECT * FROM range(100000) AS t1 INNER JOIN range(1000000) AS t2 on t1.value < (t1.value+t2.value); thread 'main' panicked at datafusion/core/src/physical_planner.rs:1310:38: internal error: entered unreachable code ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
