2010YOUY01 commented on PR #17482: URL: https://github.com/apache/datafusion/pull/17482#issuecomment-3409174009
> @2010YOUY01 I have resolved the requested changes, I have also added null handling so that it is handling nulls first, then calculating to the first index to start from based on the number of nulls in the array. > > Here are some follow up improvements: > > * Fix PWMJ predicate extraction, for now we can allow users to use PWMJ but I will include in a note for the enable PWMJ config to only enable to true for simpler predicates (for something like t.val > s.val and not t.val > (s.val + t.val)) > * Swapping inputs > * Optimize some of the cases in your comment Sounds great. Let's update the update the epic issue for follow up tasks. I have a question. How do you plan to implement swapping inputs, is there anything beyond putting smaller table on the buffer side? Besides, I suggest to support additional predicate first, so that PWMJ can be applicable to a wider scenario. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
