dqkqd commented on code in PR #18024:
URL: https://github.com/apache/datafusion/pull/18024#discussion_r2427383773
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -622,6 +626,12 @@ message WindowFrameBound {
datafusion_common.ScalarValue bound_value = 2;
}
+enum NullTreatment {
+ NULL_TREATMENT_UNSPECIFIED = 0;
Review Comment:
As described in the issue, there should be a `UNSPECIFIED` field.
This is also noted here:
https://protobuf.dev/best-practices/dos-donts/#unspecified-enum
But I don't see we are doing it for other enums.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
