timsaucer commented on PR #1276: URL: https://github.com/apache/datafusion-python/pull/1276#issuecomment-3402749792
> if @timsaucer agrees, can we expand the scope from filter and include other similar methods which are not to hard to implement, i think join_on has expression `join_on` may be a bit tricky. It is unclear to me which dataframe we should parse the expressions against. When you have column selection in the sql parsing, it returns qualified columns, so if evaluated against the wrong one you could end up in a bad state. That being said, I am not at all opposed to evaluating other places in `DataFrame` to give similar treatment to. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
