zuston commented on code in PR #2578:
URL: https://github.com/apache/datafusion-comet/pull/2578#discussion_r2434401241
##########
native/core/src/execution/shuffle/row.rs:
##########
@@ -839,6 +839,7 @@ pub fn process_sorted_row_partition(
.open(&output_path)?;
output_data.write_all(&frozen)?;
+ output_data.flush()?;
Review Comment:
> Also it's misleading to say that this avoids data loss, since flush() does
not do an fsync().
Nice comment! I forgot that file writing doesn’t require an explicit flush
when not using a buffered writer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
