Omega359 commented on code in PR #18017:
URL: https://github.com/apache/datafusion/pull/18017#discussion_r2429706593


##########
datafusion/core/src/execution/context/mod.rs:
##########
@@ -1072,6 +1074,16 @@ impl SessionContext {
         } else {
             let mut state = self.state.write();
             state.config_mut().options_mut().set(&variable, &value)?;
+
+            // Register UDFs that return values based on session configuration
+            // e.g. now() which depends on the time_zone configuration option
+            if variable == "datafusion.execution.time_zone" {

Review Comment:
   Hardcoding the variable and the function here I don't think is the correct 
approach. It may work for the few functions provided by DF that require this 
but it won't help any custom functions that might require this ability.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to