codetyri0n commented on code in PR #18040: URL: https://github.com/apache/datafusion/pull/18040#discussion_r2433378116
########## datafusion/sqllogictest/test_files/current_time_timezone.slt: ########## @@ -0,0 +1,100 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +########## +## current_time with timezone tests +########## + +# Test 1: Verify current_time is consistent within the same query (default UTC) +query B +SELECT current_time() = current_time(); +---- +true + +# Test 2: Verify data type is correct +query T +SELECT arrow_typeof(current_time()); +---- +Time64(Nanosecond) + +# Test 3: Set timezone to +08:00 and verify current_time is still stable +statement ok +SET datafusion.execution.time_zone = '+08:00'; + +query B +SELECT current_time() = current_time(); Review Comment: yeah I guess this is a more robust way to test the functionality, perhaps we can add some unit tests to the rust implementation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
