andygrove commented on PR #2537: URL: https://github.com/apache/datafusion-comet/pull/2537#issuecomment-3374195051
> lgtm. Is there any unit test for this anywhere? It's hard to tell, so I added some new tests. If I comment out the line `classOf[CheckOverflow] -> CometCheckOverflow,` then some of these tests fail. However, I was hoping to add assertions that the plan contained `CheckOverflow`, but it does not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
