alamb opened a new pull request, #17900:
URL: https://github.com/apache/datafusion/pull/17900
## Which issue does this PR close?
- part of https://github.com/apache/datafusion/issues/15791
- replaces some parts of this PR:
https://github.com/apache/datafusion/pull/16978
## Rationale for this change
While working on the arrow 57 upgrade,
- https://github.com/apache/datafusion/pull/17888
I had to change quite few tests in enforce_sorting and the fact they are
not yet ported to insta means it was very painful to do.
## What changes are included in this PR?
rewrite `enforce_sorting` so it uses insta for plan snapshots rather than
hard coded vec<&str>
Also avoid the use of a macro for easier maintenance (and hopefully faster
compile time)
## Are these changes tested?
Yes, by existing tests
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
