wForget commented on code in PR #2425:
URL: https://github.com/apache/datafusion-comet/pull/2425#discussion_r2422846731
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1046,6 +1046,29 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
castTest(generateDecimalsPrecision10Scale2(),
DataTypes.createDecimalType(10, 0))
}
+ test("cast ArrayType to StringType") {
+ val scanImpl = sys.env
+ .getOrElse(
+ "COMET_PARQUET_SCAN_IMPL",
+ conf.getConfString(CometConf.COMET_NATIVE_SCAN_IMPL.key,
"native_comet"))
+ val isNativeCometScan = scanImpl == "native_comet"
Review Comment:
`hasIncompatibleType` argument seems to only check if there is a fallback
scan. We can also use
`CometScanTypeChecker(CometConf.COMET_NATIVE_SCAN_IMPL.get()).isTypeSupported(...)`
to check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
