alamb commented on PR #17819: URL: https://github.com/apache/datafusion/pull/17819#issuecomment-3353343828
> > I have an alternate suggestion which avoids the `clone()` as well here: > > > > * [Avoid some clones using `impl IntoIterator` #17831](https://github.com/apache/datafusion/pull/17831) > > This works fine today, but the IntoIterator-based API is significantly less powerful. You can iterate only once (so eg you cannot call 2+ downstream functions that you want to pass the collection into) and you cannot check the length upfront (eg to size the buffer or check two params are same length). Yeah, I am fine with this change (though note https://github.com/apache/datafusion/pull/17831 the additional flexibility of passing in a slice is not actually used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
