andygrove commented on code in PR #2584: URL: https://github.com/apache/datafusion-comet/pull/2584#discussion_r2433834234
########## docs/source/contributor-guide/benchmarking_aws_ec2.md: ########## @@ -104,7 +104,7 @@ make release Set `COMET_JAR` environment variable. ```shell -export COMET_JAR=/home/ec2-user/datafusion-comet/spark/target/comet-spark-spark3.5_2.12-0.11.0-SNAPSHOT.jar +export COMET_JAR=/home/ec2-user/datafusion-comet/spark/target/comet-spark-spark3.5_2.12-0.12.0-SNAPSHOT.jar Review Comment: The version should not have been hard-coded here (this was my mistake in an earlier PR). We can update as part of this PR or separately. ```suggestion export COMET_JAR=/home/ec2-user/datafusion-comet/spark/target/comet-spark-spark3.5_2.12-$COMET_VERSION.jar ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
