Dandandan commented on code in PR #17592:
URL: https://github.com/apache/datafusion/pull/17592#discussion_r2413666241
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/mod.rs:
##########
@@ -251,12 +284,27 @@ struct VectorizedOperationBuffers {
impl VectorizedOperationBuffers {
fn clear(&mut self) {
- self.append_row_indices.clear();
+ self.clear_append_row_indices();
self.equal_to_row_indices.clear();
self.equal_to_group_indices.clear();
self.equal_to_results.clear();
self.remaining_row_indices.clear();
}
+
+ fn add_append_row_index(&mut self, row: usize) {
Review Comment:
It would probably faster and somewhat cleaner to do this in a single check
on `append_row_indices` in `vectorized_append`,
something like:
```
append_row_indices.windows(2).all(|[x, y]| x + 1 == y)
```
will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
