andygrove commented on PR #2523:
URL:
https://github.com/apache/datafusion-comet/pull/2523#issuecomment-3377203204
Current Comet performance for `date_trunc` isn't great according to
`CometDatetimeExpressionBenchmark`.
```
Running benchmark: Date Truncate - YEAR
Running case: Date Truncate - YEAR - Spark
Stopped after 38 iterations, 2006 ms
Running case: Date Truncate - YEAR - Comet
Stopped after 39 iterations, 2022 ms
OpenJDK 64-Bit Server VM 11.0.28+6-post-Ubuntu-1ubuntu122.04.1 on Linux
6.8.0-84-generic
AMD Ryzen 9 7950X3D 16-Core Processor
Date Truncate - YEAR: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
Date Truncate - YEAR - Spark 46 53
6 23.0 43.5 1.0X
Date Truncate - YEAR - Comet 46 52
5 22.6 44.2 1.0X
Running benchmark: Date Truncate - YYYY
Running case: Date Truncate - YYYY - Spark
Stopped after 46 iterations, 2019 ms
Running case: Date Truncate - YYYY - Comet
Stopped after 42 iterations, 2006 ms
OpenJDK 64-Bit Server VM 11.0.28+6-post-Ubuntu-1ubuntu122.04.1 on Linux
6.8.0-84-generic
AMD Ryzen 9 7950X3D 16-Core Processor
Date Truncate - YYYY: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
Date Truncate - YYYY - Spark 39 44
6 26.6 37.6 1.0X
Date Truncate - YYYY - Comet 43 48
6 24.4 40.9 0.9X
Running benchmark: Date Truncate - YY
Running case: Date Truncate - YY - Spark
Stopped after 51 iterations, 2010 ms
Running case: Date Truncate - YY - Comet
Stopped after 44 iterations, 2040 ms
OpenJDK 64-Bit Server VM 11.0.28+6-post-Ubuntu-1ubuntu122.04.1 on Linux
6.8.0-84-generic
AMD Ryzen 9 7950X3D 16-Core Processor
Date Truncate - YY: Best Time(ms) Avg Time(ms)
Stdev(ms) Rate(M/s) Per Row(ns) Relative
------------------------------------------------------------------------------------------------------------------------
Date Truncate - YY - Spark 37 39
3 28.6 34.9 1.0X
Date Truncate - YY - Comet 43 46
6 24.5 40.8 0.9X
```
I tried running against this PR but got similar failures to the ones we are
seeing in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
