theirix commented on PR #17633: URL: https://github.com/apache/datafusion/pull/17633#issuecomment-3325694690
> Thank you @theirix -- this is an amazing PR that shows how to "support your own SQL" dialect. I am sorry for the delay in reviewing > > I recommend we call this example something more general like "custom_sql_dialect" or something (we can rename it as a follow on PR) > > I also had several suggestions on how we can improve / simplify this example / improve the underlying APIs as well, though they can also be done as follow ons I think, if you prefer. > > What I suggest is: > > 1. Implement some of the simpler changes (move `main` up, add comments, simplify `Eq`, cleanup imports, etc) > > 2. Merge this PR > > 3. Work on improvements to API and comments as follow on PRs (you don't have to do it) > > > Again, this is really really cool. I have dreamed about this type of example for years 💤 Thank you! I am glad it helps showcase Datafusion's extensibility. It wasn't immediately clear to me how to approach it, so it could be helpful for developers as a reference or a starting point. I have attempted to address most of the review suggestions, including a small core API change. I would prefer to move with smaller iterations with follow-ups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
