alamb commented on code in PR #17945:
URL: https://github.com/apache/datafusion/pull/17945#discussion_r2408541189
##########
datafusion/common/src/dfschema.rs:
##########
@@ -1417,9 +1417,7 @@ mod tests {
fn from_qualified_schema_into_arrow_schema() -> Result<()> {
let schema = DFSchema::try_from_qualified_schema("t1",
&test_schema_1())?;
let arrow_schema = schema.as_arrow();
- let expected = "Field { name: \"c0\", data_type: Boolean, nullable:
true, dict_id: 0, dict_is_ordered: false, metadata: {} }, \
- Field { name: \"c1\", data_type: Boolean, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }";
- assert_eq!(expected, arrow_schema.to_string());
+ insta::assert_snapshot!(arrow_schema.to_string(), @r#"Field { name:
"c0", data_type: Boolean, nullable: true, dict_id: 0, dict_is_ordered: false,
metadata: {} }, Field { name: "c1", data_type: Boolean, nullable: true,
dict_id: 0, dict_is_ordered: false, metadata: {} }"#);
Review Comment:
by changing this to `assert_snapshot` it is easier to update in the arrow-57
upgrade, where this message changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
