alamb commented on code in PR #17945:
URL: https://github.com/apache/datafusion/pull/17945#discussion_r2408543841
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -2486,7 +2486,7 @@ mod tests {
// the cast here is implicit so has CastOptions with safe=true
let expected = r#"BinaryExpr { left: Column { name: "c7", index: 2 },
op: Lt, right: Literal { value: Int64(5), field: Field { name: "lit",
data_type: Int64, nullable: false, dict_id: 0, dict_is_ordered: false,
metadata: {} } }, fail_on_overflow: false }"#;
- assert!(format!("{exec_plan:?}").contains(expected));
+ assert_contains!(format!("{exec_plan:?}"), expected);
Review Comment:
likewise this makes it easier to update the test as now the actual output is
also printed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
