BlakeOrth opened a new pull request, #18000:
URL: https://github.com/apache/datafusion/pull/18000
## Which issue does this PR close?
This does not fully close, but is an incremental building block component
for:
- https://github.com/apache/datafusion/issues/17207
Functionally this code currently does nothing, but it will allow users to
change the mode of an instrumented object store through either a CLI flag or
with a runtime command.
The full context of how this code is likely to progress can be seen in the
POC for this effort:
- https://github.com/apache/datafusion/pull/17266
## Rationale for this change
This is another bite-sized building block on the road to completing #17207
## What changes are included in this PR?
- Adds mode type to allow changing the mode of an InstrumentedObjectStore
to datafusion-cli
- Implements string parsing and u8 conversion for
InstrumentedObjectStoreMode
- Adds tests to validate trait implementations
## Are these changes tested?
Yes. Unit tests have been added for the trait implementations on this new
type.
## Are there any user-facing changes?
No.
cc @alamb
(I'm trying to keep these as small as possible and have them still make
sense, however the PRs following this one will likely start to introduce real
functionality and may end up being a bit larger)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
