ramnes commented on code in PR #2015:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2015#discussion_r2372506543
##########
src/ast/mod.rs:
##########
@@ -3314,6 +3314,8 @@ pub enum Statement {
CreateRole {
names: Vec<ObjectName>,
if_not_exists: bool,
+ /// Whether ROLE or USER keyword was used
+ keyword: RoleKeyword,
Review Comment:
From what I see of that PR it is modeled on the current `CreateUser`
structure, that only supports Snowflake.
So my understanding is that we'll have `CreateUser` and `AlterUser` that
work for Snowflake, `CreateRole` and `AlterRole` that work for PostgreSQL, and
no support for the opposite keyword / technology combo (`CREATE USER` support
on PostgreSQL, or `CREATE ROLE` support on Snowflake).
I'd be happy to see the four structures unified into something that work for
both technologies but I don't think I can do that at the moment, alas. :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
