iffyio commented on code in PR #2015:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2015#discussion_r2372044464
##########
src/ast/mod.rs:
##########
@@ -3314,6 +3314,8 @@ pub enum Statement {
CreateRole {
names: Vec<ObjectName>,
if_not_exists: bool,
+ /// Whether ROLE or USER keyword was used
+ keyword: RoleKeyword,
Review Comment:
Sorry for the delay in getting back to this. I think ideally we would use
separate representations, it would likely be confusing if a `CREATE USER`
statement was being parsed as an `CREATE ROLE` statement or vice versa by the
parser.
Also heads up there is a related PR adding `ALTER USER`
[here](https://github.com/apache/datafusion-sqlparser-rs/pull/2035)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
