alamb commented on code in PR #17898:
URL: https://github.com/apache/datafusion/pull/17898#discussion_r2403297323
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -208,10 +208,19 @@ impl CaseExpr {
let mut current_value = new_null_array(&return_type, batch.num_rows());
// We only consider non-null values while comparing with whens
let mut remainder = not(&base_nulls)?;
+ let mut remainder_count = remainder.true_count();
Review Comment:
we have found in past evaluations, that the code generated for `true_count`
is astonishingly fast (it uses some special hardware instruction) so I am not
surprised this works well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
