pepijnve commented on code in PR #17898:
URL: https://github.com/apache/datafusion/pull/17898#discussion_r2442426949
##########
datafusion/physical-expr/src/expressions/case.rs:
##########
@@ -277,10 +287,15 @@ impl CaseExpr {
// start with nulls as default output
let mut current_value = new_null_array(&return_type, batch.num_rows());
let mut remainder = BooleanArray::from(vec![true; batch.num_rows()]);
+ let mut remainder_count = batch.num_rows();
Review Comment:
In #18152 the code is changing a bit further. If the approach there pans out
I want to try to do the same for `case_when_with_expr`. It'll be easier to see
if there's an extractable pattern once that work settles down, so if it's ok
with you I would like to postpone your suggestion for a little bit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
