ashdnazg opened a new pull request, #2571: URL: https://github.com/apache/datafusion-comet/pull/2571
## Which issue does this PR close? Closes #1645 kinda. ## Rationale for this change Boxed `dyn ArrayBuilder`s implement `ArrayBuilder` and as we do dynamic downcasting anyway, we don't win anything by having the `append_map_elements` function be generic. The saving in library size is crazy, measured by Cargo bloat (`cargo bloat --release --filter comet`). Before: ``` 0.2% 3.1% 1.9MiB filtered data size, the file size is 885.0MiB ``` After: ``` 0.1% 1.2% 734.3KiB filtered data size, the file size is 868.9MiB ``` Another benefit is the added support to nested types. ## How are these changes tested? Regular test suite should check the existing types. We should probably add tests for nested types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
