LorrensP-2158466 commented on issue #17719: URL: https://github.com/apache/datafusion/issues/17719#issuecomment-3381701074
> I think this one makes sense as it is the most flexible. Making JoinGraph itself a trait seems like it might make it hard to reuse a common query representation Definitely agreed. Having a consistent way of how the JoinGraph is represented will make it easier to define the api around it. > I was thinking of something like this: Why would we provide an extra trait for this? Couldn't we provide a function on `LogicalPlan` and add it to the `UserDefinedLogicalNode` trait? Or am I missing something here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
