comphead commented on code in PR #2581:
URL: https://github.com/apache/datafusion-comet/pull/2581#discussion_r2433236191
##########
common/src/main/scala/org/apache/comet/CometConf.scala:
##########
@@ -106,13 +107,13 @@ object CometConf extends ShimCometConf {
val COMET_NATIVE_SCAN_IMPL: ConfigEntry[String] =
conf("spark.comet.scan.impl")
.category(CATEGORY_SCAN)
.doc(
- s"The implementation of Comet Native Scan to use. Available modes are
'$SCAN_NATIVE_COMET'," +
- s"'$SCAN_NATIVE_DATAFUSION', and '$SCAN_NATIVE_ICEBERG_COMPAT'. " +
- s"'$SCAN_NATIVE_COMET' is for the original Comet native scan which
uses a jvm based " +
+ s"The implementation of Comet Native Scan to use. Available modes are
`$SCAN_NATIVE_COMET`," +
+ s"`$SCAN_NATIVE_DATAFUSION`, and `$SCAN_NATIVE_ICEBERG_COMPAT`. " +
Review Comment:
its not a problem of this PR, but something caught my eye, why the dollar
sign here? is it part of the formatting?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
