ahmed-mez commented on code in PR #18099:
URL: https://github.com/apache/datafusion/pull/18099#discussion_r2438494172
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -866,6 +866,7 @@ pub fn comparison_coercion_numeric(
return Some(lhs_type.clone());
}
binary_numeric_coercion(lhs_type, rhs_type)
+ .or_else(|| dictionary_comparison_coercion_numeric(lhs_type, rhs_type,
true))
Review Comment:
There's a subtle issue with reusing `dictionary_comparison_coercion` as is:
`dictionary_comparison_coercion` calls `comparison_coercion` recursively, but
we need it to call `comparison_coercion_numeric` to maintain the different
semantics (numeric vs string preference).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
