iffyio commented on code in PR #2068: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2068#discussion_r2432166788
########## src/ast/visitor.rs: ########## @@ -124,6 +124,10 @@ visit_noop!(bigdecimal::BigDecimal); /// node and `post_visit_` methods are invoked after visiting all /// children of the node. /// +/// Important note: The `Break` type should be kept as small as possible to prevent Review Comment: could we place the note on the documentation of `Break` instead? [here for example](https://github.com/niebayes/datafusion-sqlparser-rs/blob/6419cbd073d6fda4f8b43e7b320d9642ae1bba66/src/ast/visitor.rs#L300) ########## src/ast/visitor.rs: ########## @@ -124,6 +124,10 @@ visit_noop!(bigdecimal::BigDecimal); /// node and `post_visit_` methods are invoked after visiting all /// children of the node. /// +/// Important note: The `Break` type should be kept as small as possible to prevent Review Comment: could we place the note on the documentation of `Break` instead? [here for example](https://github.com/niebayes/datafusion-sqlparser-rs/blob/6419cbd073d6fda4f8b43e7b320d9642ae1bba66/src/ast/visitor.rs#L300) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
