andygrove commented on code in PR #2412:
URL: https://github.com/apache/datafusion-comet/pull/2412#discussion_r2392444077
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -118,6 +118,11 @@ class CometExecSuite extends CometTestBase {
val (_, cometPlan) = checkSparkAnswer(df)
val infos = new ExtendedExplainInfo().generateExtendedInfo(cometPlan)
assert(infos.contains("Dynamic Partition Pruning is not supported"))
+
+ withSQLConf(CometConf.COMET_EXPLAIN_VERBOSE_ENABLED.key -> "true") {
+ val extendedExplain = new
ExtendedExplainInfo().generateExtendedInfo(cometPlan)
+ assert(extendedExplain.contains("Comet accelerated 33% of eligible
operators"))
Review Comment:
I was wrong. There is a failure due to a different percentage. I will make
the test less specific.
```
- DPP fallback *** FAILED *** (1 second, 553 milliseconds)
"BroadcastHashJoin
:- ColumnarToRow
: +- Scan parquet [COMET: Dynamic Partition Pruning is not supported]
: +- SubqueryBroadcast
: +- BroadcastExchange
: +- CometColumnarToRow
: +- CometFilter
: +- CometScan [native_iceberg_compat] parquet
+- BroadcastExchange
+- CometColumnarToRow
+- CometFilter
+- CometScan [native_iceberg_compat] parquet
Comet accelerated 4 out of 9 eligible operators (44%). Final plan contains
3 transitions between Spark and Comet." did not contain "Comet accelerated 33%
of eligible operators" (CometExecSuite.scala:124)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
