martin-g commented on code in PR #17858:
URL: https://github.com/apache/datafusion/pull/17858#discussion_r2394445051
##########
datafusion/datasource-parquet/src/source.rs:
##########
@@ -313,16 +313,9 @@ impl ParquetSource {
self
}
- fn with_metrics(mut self, metrics: ExecutionPlanMetricsSet) -> Self {
- self.metrics = metrics;
- self
- }
-
/// Set predicate information
pub fn with_predicate(&self, predicate: Arc<dyn PhysicalExpr>) -> Self {
Review Comment:
This method is a bit strange.
The other `with_**()` methods accept `mut self` and modify in-place. Only
this method accepts `&self` and makes a clone of itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
