dqkqd commented on code in PR #18104:
URL: https://github.com/apache/datafusion/pull/18104#discussion_r2442688615
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -6479,3 +6479,87 @@ async fn
test_duplicate_state_fields_for_dfschema_construct() -> Result<()> {
Ok(())
}
+
+#[tokio::test]
+async fn array_distinct_on_list_with_inner_nullability_causing_type_mismatch(
Review Comment:
I don't like this test, I wish I could write `slt`.
But I don't know how to construct a nullable array from sql.
Maybe with this improvement from `arrow-rs`
(https://github.com/apache/arrow-rs/issues/8351),
we can write something like this in the future:
`select arrow_cast([1,2,3], 'List(Int64)')` (for nullable = false)
and
`select arrow_cast([1,2,3], 'List(nullable Int64)')` (for nullable = true)
(then lots of tests with nested data type can be rewritten into `slt` tests)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
