dqkqd commented on PR #18104: URL: https://github.com/apache/datafusion/pull/18104#issuecomment-3420023180
> Looks good, though I wonder if it is necessary to pull in rstest just for this single case? I was thinking to add more cases (e.g. `DataType::LargeList`), and more tests (for `array_union`, `array_intersect`). But it might be unnecessary, those can be removed later in favor of equivalent `slt` tests, once we have a way to construct nested data types with different inner nullability in sql. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
