alamb commented on code in PR #18146:
URL: https://github.com/apache/datafusion/pull/18146#discussion_r2443279129
##########
datafusion/catalog-listing/src/helpers.rs:
##########
@@ -1030,72 +939,7 @@ mod tests {
.unwrap();
}
- (Arc::new(memory), Arc::new(MockSession {}))
- }
-
- struct MockSession {}
-
- #[async_trait]
- impl Session for MockSession {
- fn session_id(&self) -> &str {
- unimplemented!()
- }
-
- fn config(&self) -> &SessionConfig {
- unimplemented!()
- }
-
- async fn create_physical_plan(
- &self,
- _logical_plan: &LogicalPlan,
- ) -> Result<Arc<dyn ExecutionPlan>> {
- unimplemented!()
- }
-
- fn create_physical_expr(
- &self,
- _expr: Expr,
- _df_schema: &DFSchema,
- ) -> Result<Arc<dyn PhysicalExpr>> {
- unimplemented!()
- }
-
- fn scalar_functions(&self) -> &std::collections::HashMap<String,
Arc<ScalarUDF>> {
- unimplemented!()
- }
-
- fn aggregate_functions(
- &self,
- ) -> &std::collections::HashMap<String, Arc<AggregateUDF>> {
- unimplemented!()
- }
-
- fn window_functions(&self) -> &std::collections::HashMap<String,
Arc<WindowUDF>> {
- unimplemented!()
- }
-
- fn runtime_env(&self) -> &Arc<RuntimeEnv> {
- unimplemented!()
- }
-
- fn execution_props(&self) -> &ExecutionProps {
- unimplemented!()
- }
-
- fn as_any(&self) -> &dyn Any {
- unimplemented!()
- }
-
- fn table_options(&self) -> &TableOptions {
- unimplemented!()
- }
-
- fn table_options_mut(&mut self) -> &mut TableOptions {
- unimplemented!()
- }
-
- fn task_ctx(&self) -> Arc<datafusion_execution::TaskContext> {
- unimplemented!()
- }
+ let state = SessionStateBuilder::new().build();
Review Comment:
In order to avoid circular dependencies (needed to allow datafusion to
compile faster) the API needed for the catalog is in the `Session` trait, which
is implemented by SessionState, but can be implemented by other things
Thus, in this case the options are:
1. Keep the MockSession and implement whatever APIs it needs
2. Move the tests to the `datafusion` crate (e.g. somewhere in
https://github.com/apache/datafusion/blob/main/datafusion/core/tests/core_integration.rs)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
