alamb commented on code in PR #18146:
URL: https://github.com/apache/datafusion/pull/18146#discussion_r2445761351
##########
datafusion/catalog-listing/src/helpers.rs:
##########
@@ -239,105 +238,6 @@ pub async fn list_partitions(
Ok(out)
}
-async fn prune_partitions(
Review Comment:
I reviewed some of the context of this code that does multi-level pruning of
partitions, see
- https://github.com/apache/datafusion/pull/6183#issuecomment-1550338507
In that case, @kdbrooks reported querying a remote table with 27,000
partitions
> I want to surface that I believe there is a chance for a performance
regression for certain queries against certain tables. One performance related
mechanism the existing code implements, but this code currently omits, is
(potentially) reducing the number of partitions listed based on query filters.
In order for the existing code to exercise this optimization the query filters
must contain all the path elements of a subdirectory as column filters.
Thus I think this may need to be reconsidered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
