comphead commented on PR #17482: URL: https://github.com/apache/datafusion/pull/17482#issuecomment-3424208380
Thanks @jonathanc-n I think it is great. Just double checked it is disabled by default. Before going live we need a reliable fuzzer to prove the performance is not impacted like it was recently reported by user, whereas local tests were fine. One thing to add though: it would probably be great to have a user documentation in `.md` file so they would be aware how and when to use this feature, it might totally happen for some workload this feature would be much more performant that standard approach. But the user would like to know about it at least. This documentation can be done separately, thanks again 💪 and for @2010YOUY01 for having such detailed and thorough review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
