adriangb commented on code in PR #17337:
URL: https://github.com/apache/datafusion/pull/17337#discussion_r2448398850
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -247,6 +248,8 @@ impl Optimizer {
Arc::new(EliminateOuterJoin::new()),
// Filters can't be pushed down past Limits, we should do
PushDownFilter after PushDownLimit
Arc::new(PushDownLimit::new()),
+ // Sort pushdown should happen before filter pushdown to maximize
optimization opportunities
Review Comment:
As per
https://github.com/apache/datafusion/pull/17337#issuecomment-3426761928 I'm
doing it at the logical layer because that's where sort orders of scans is
currently handled. But maybe this is different enough from the current handling
of sort orders to warrant changing that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
